Padded encoded ULIDs to canonical length#11
Merged
Conversation
rkadaj
changed the title
rkadaj
force-pushed
the
rkadaj/ensure-encoded-ulid-is-26-chars
branch
from
aadda48 to
7b2b615
Compare
martelogan
approved these changes
Jun 4, 2026
Member
martelogan
left a comment
martelogan
left a comment
There was a problem hiding this comment.
This should be good 👍 ; mentioned in a comment (and per slack) that I believe the prior version was just inherited from some encode32 micro-optimizations which asumed the shortest possible underlying ULID representation before serializing
| return "0#{b32}" if b32.length == 25 | ||
|
|
||
| b32 | ||
| b32.rjust(26, "0") |
Member
There was a problem hiding this comment.
👍 , per discussion on slack, this should be fine as I believe the prior version was just a micro-optimization assuming a single leading zero for 25-char ULIDs generated using the shortest possible representation, but there should be no issue to replace with rjust(26, "0") to handle an arbitrary number of leading zeroes for alternative underlying representations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right justify encoded ULID to ensure 26 character length regardless of initial value